[fprint] (NEW) Secugen FDU2000 Driver

[Gustavo Chain]

El Wed, 19 Dec 2007 14:38:23 +0000
Daniel Drake <dan at reactivated.net> escribió:

> Gustavo Chain wrote:
> > I've implemented memmem as a driver function.
> 
> OK. I looked too and it doesn't look like glib offers an equivalent. 
> Maybe I'll contribute this at some point.
That's why I've implemented into driver
> 
> >> You should probably do error checking in bulk_write_safe() callers
> >> as this may help detect weird bugs early on in future.
> > Implemented as macro (may be isn't nice)
> 
> I'd rather see it "open coded".
What did you mean with "open coded" (My english isn't the best)
> 
> You're still using inappropriate constants for endpoint addressing. 
> Stick to a number OR'd with USB_ENDPOINT_IN or USB_ENDPOINT_OUT. If
> you wish to give more meaningful names to endpoints, you can #define
> them like I do in other drivers.
> 
something like:
#define EP_INTR                 (1 | USB_ENDPOINT_IN)

> Thanks!
> Daniel
> 

Thanks you!

-- 
Gustavo Chaín Dumit
http://0xff.cl