[fprint] (NEW) Secugen FDU2000 Driver

[Daniel Drake]

Gustavo Chain wrote:
> El Wed, 19 Dec 2007 14:38:23 +0000
> Daniel Drake <dan at reactivated.net> escribió:
> 
>> Gustavo Chain wrote:
>>> I've implemented memmem as a driver function.
>> OK. I looked too and it doesn't look like glib offers an equivalent. 
>> Maybe I'll contribute this at some point.
> That's why I've implemented into driver
>>>> You should probably do error checking in bulk_write_safe() callers
>>>> as this may help detect weird bugs early on in future.
>>> Implemented as macro (may be isn't nice)
>> I'd rather see it "open coded".
> What did you mean with "open coded" (My english isn't the best)

Instead of using a macro, code each call returning it's result into a 
variable. Then check the value of the variable, and if it's an error, 
abort. For those cases, add in an error message for conditions that you 
think are likely to happen at some point.

This is pretty much what your macro does, but I think it's better to 
avoid the macro and just write this code openly - make it obvious that 
you're checking for errors and how errors are handled.

Thanks,
Daniel