[fprint] (NEW) Secugen FDU2000 Driver
Daniel Drake
dan at reactivated.net
Wed Dec 19 14:38:23 GMT 2007
Gustavo Chain wrote:
> I've implemented memmem as a driver function.
OK. I looked too and it doesn't look like glib offers an equivalent.
Maybe I'll contribute this at some point.
>> You should probably do error checking in bulk_write_safe() callers as
>> this may help detect weird bugs early on in future.
> Implemented as macro (may be isn't nice)
I'd rather see it "open coded".
You're still using inappropriate constants for endpoint addressing.
Stick to a number OR'd with USB_ENDPOINT_IN or USB_ENDPOINT_OUT. If you
wish to give more meaningful names to endpoints, you can #define them
like I do in other drivers.
Thanks!
Daniel
More information about the fprint
mailing list