[fprint] modular libfprint

Pavel Herrmann morpheus.ibis at gmail.com
Sun Jul 20 11:29:15 BST 2008


Daniel Drake wrote:
> I know I designed how it is at the moment, but I think we should 
> change how imagemagick is called. Instead of supporting 
> imgdev->enlarge_factor, aes4000 should just call im_resize() directly, 
> and claim that the returned images are sized appropriately. im_resize 
> and supporting code can then be moved into it's own file, similar to 
> how aeslib is. This allows us to separate the resizing hack from the 
> non-hacky code, and also gets rid of REQUIRE_IMAGEMAGICK ifdefs.
>
Sorry, I don't (yet) understand the structure of the drivers so I can't 
do a thing about this one, plus I don't want to start messing with 
something I have no chance to test, sorry.

> Also, you can avoid having to do cflags modifications like this one:
>     libfprint_la_CFLAGS += -DENABLE_URU4000
> by using AC_DEFINE in configure.ac to place an entry in config.h
>
> Thanks!
> Daniel

OK, thanks, done :)
Only it didn't clean things the way I thought it would, AM_CONDITIONALs 
are still there as autoconf complained when i tried to manage DRIVER_SRC 
in configure.ac ("configure substitutions are not allowed in _SOURCES 
variables"). Any other way around it?

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modular.diff
Type: text/x-patch
Size: 8027 bytes
Desc: not available
Url : http://lists.reactivated.net/pipermail/fprint/attachments/20080720/3016b343/modular.bin


More information about the fprint mailing list